[Swapsteem] Profile Image Errors on Wallet
Project Information
- Repository: https://github.com/nirvanaitsolutions/swapsteem
- Project Name: SwapSteem
Expected behavior
A user's profile image should always be displayed correctly when viewing your wallet.
Actual behavior
When viewing a users profile on the profile page, the profile image doesn't display correctly. It shows a broken image.
How to reproduce
- Go to your wallet.
- Note that your profile image doesn't load.
I suspect this isn't happening to every user, this may not be easy to replicate.
Video/Screenshots
The following screenshot provides additional clarity surrounding the issue:
Issue & Resolution
Currently, profile images are pulled from a user's json_metadata as seen in the following code:
https://github.com/nirvanaitsolutions/swapsteem/blob/master/src/app/profile/profile.component.ts
In order to resolve this issue and overall reduce the risk of error by providing an easy solution for fallback. The profile image should no longer be pulled from the json_metadata and overall can be simplified by using the following URL to load a user's profile image.
https://steemitimages.com/u/<username>/avatar
Simple replace <username> with tobias-g (no @ required) to view my profile image.
Enviroment
- Browser: Google Chrome (Version 71.0.3578.98 (Official Build) (64-bit))
- Device: MacBook Pro (Retina, 15-inch, Late 2013)
- Operating system: MacOS Mojave Version 10.14.1 (18B75)
GitHub Account
A link to my GitHub account can be found here:
This issue was reported on GitHub here:
Hi @tobias-g, thanks for making this contribution.
I am able to replicate this behavior. The profile picture failed to load in the wallet page.
I see this has been acknowledged by the PO and it looked as though initially there were plans to have it fixed. It is particularly strange that the issue was closed without a fix.
The steps were an easy walk through. I like manner in which you described what could have possibly resulted in the bug. The fix you proposed was well detailed. Since the bug is yet to be fixed, we cannot be certain if that would have solved the case.
Thanks again for the contribution :)
Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.
To view those questions and the relevant answers related to your post, click here.
Need help? Chat with us on Discord.
[utopian-moderator]
Thank you for your review, @fego! Keep up the good work!
Thank you @tobias-g for the bug, although the screenshot I am seeing appears to be from older version of the app. Can you try to reproduce the same with the latest application at www.swapsteem.online
Hi @svijay1692,
You're correct it is an older version, this was related to the issue on reported on 25th January 2019, however, I only just got round to posting on Utopian now. The issue can be found here:
https://github.com/nirvanaitsolutions/swapsteem/issues/53
I did however take another look and the issue is still present on the latest build, please see the screenshot below:
Hi, @tobias-g!
You just got a 1.27% upvote from SteemPlus!
To get higher upvotes, earn more SteemPlus Points (SPP). On your Steemit wallet, check your SPP balance and click on "How to earn SPP?" to find out all the ways to earn.
If you're not using SteemPlus yet, please check our last posts in here to see the many ways in which SteemPlus can improve your Steem experience on Steemit and Busy.
Congratulations @tobias-g! You have completed the following achievement on the Steem blockchain and have been rewarded with new badge(s) :
Click here to view your Board
If you no longer want to receive notifications, reply to this comment with the word
STOPHi @tobias-g!
Your post was upvoted by @steem-ua, new Steem dApp, using UserAuthority for algorithmic post curation!
Your post is eligible for our upvote, thanks to our collaboration with @utopian-io!
Feel free to join our @steem-ua Discord server
Hey, @tobias-g!
Thanks for contributing on Utopian.
We’re already looking forward to your next contribution!
Get higher incentives and support Utopian.io!
Simply set @utopian.pay as a 5% (or higher) payout beneficiary on your contribution post (via SteemPlus or Steeditor).
Want to chat? Join us on Discord https://discord.gg/h52nFrV.
Vote for Utopian Witness!