You are viewing a single comment's thread from:
RE: Updating the League of Legends PMTC
- Great article as usual with great use of animated gif and beautiful code samples.
- Great commit messages and separation of concerns.
- Don't you think the inline svg makes the code a little messy?
- Would you say there are less hardcoded bits this version this time around?
Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.
To view those questions and the relevant answers related to your post, click here.
Need help? Chat with us on Discord.
Thanks for the review, Helo! I agree about the SVG being a bit messy, but I didn't want to add an entire package just so I could use 1 icon, and it was a last minute thing I added. Maybe I'll convert it to a separate icon component and use that instead.
As for it being less hardcoded: definitely! In the previous version I made a hardcoded
champions.jsonfile and was using that. Obviously with new champions being released this quickly became annoying to maintain, so now it retrieves the current patch from Riot's API and then uses that to find an up-to-date list of champions.I'm also glad to say it has already been used by others today, as you can see here.
Thank you for your review, @helo! Keep up the good work!