You are viewing a single comment's thread from:

RE: Beem-0.20.14: beempy verify --use-api fails with TypeError

in #utopian-io6 years ago

Hi @stmdev, thanks for making this contribution..

JSON serialization can be tricky at times, try to be too careful and you still mix it up.. Good find.

I see you already fixed this and your pull request was approved and merged.

My feedback:

  1. I like how you explained the function of the beempy verify command and then went on to describe what the error was. By this you pointed the difference in behavior between what was expected and what was currently at play.

  2. The steps you provided are such that the tester or PO can just copy and paste to replicate the error.

The report adds significant value to the beem project. We look forward to more of your contributions.

Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.

To view those questions and the relevant answers related to your post, click here.


Need help? Write a ticket on https://support.utopian.io/.
Chat with us on Discord.
[utopian-moderator]

Sort:  

Thank you for your review, @fego! Keep up the good work!