[busy] SBD price & estimated account value are not working

in #utopian-io5 years ago (edited)

Project Information

Issue: https://github.com/busyorg/busy/issues/2207

While there is no response on the issue, I personally contacted the PO, so the bug is acknowledged and I'll fix this. In addition, you can see this bug anytime.

Expected behavior

SBD market price and estimated account value should be shown

Actual behavior

SBD price & estimated account value are not working

How to reproduce

Visit wallet page. e.g., https://busy.org/@ned/transfers

Cause

This is because SBD market price can't be fetched. Estimated account value uses SBD price, so it shows waiting icon.

  • Browser: Any
  • Operating system: Any

Recording Of The Bug

  • no SBD market price
  • infinite waiting icon for Est. account value

Cause and fix

https://github.com/busyorg/busy/blob/27dd2383806eda8daf46748cbbbb26739d08ced4/src/client/user/UserWallet.js#L135-L139

The previous API doesn't provide SBD price anymore.

Thus, SBD price can't be shown and the est. account value which needs SBD price can't be calculated.

https://postpromoter.net/api/prices (Steem Engine uses this, and my SCOT VP viewer: https://economicstudio.github.io/vp/ also uses this, and it's quite stable) is a good alternative for STEEM & SBD price quote.

GitHub Account

https://github.com/economicstudio

Sort:  

Hi @blockchainstudio, thanks for making this report

I noticed this same issue as well while checking the est. account value on the busy.org wallet. I had to use a different frontend for this purpose. I like that you have provided a detailed analysis like you usually do.

Thanks again for the very detailed report. I look forward to reviewing more of your contributions.

Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.

To view those questions and the relevant answers related to your post, click here.


Need help? Chat with us on Discord.

[utopian-moderator]

Thank you for your review, @fego! Keep up the good work!

favcau님이 blockchainstudio님을 멘션하셨습니당. 아래 링크를 누르시면 연결되용~ ^^
favcau님의 Suggestions category - Weekly report: #39

...Keychain Scot Token Transfer Confirmation Step blockchainstudio/td> 75 syedumair Steem...

Hey, @blockchainstudio!

Thanks for contributing on Utopian.
We’re already looking forward to your next contribution!

Get higher incentives and support Utopian.io!
Simply set @utopian.pay as a 5% (or higher) payout beneficiary on your contribution post (via SteemPlus or Steeditor).

Want to chat? Join us on Discord https://discord.gg/h52nFrV.

Vote for Utopian Witness!

Coin Marketplace

STEEM 0.27
TRX 0.11
JST 0.030
BTC 67734.06
ETH 3803.47
USDT 1.00
SBD 3.47