You are viewing a single comment's thread from:

RE: Coogger Update | Admin Interface - Share Button - Coogger.reward - Editor Templates and Desing

in #coogger6 years ago

Thanks for the contribution, @hakancelik! A lot of work obviously went into this and you added some cool new features - keep up the great work!

A few thoughts about your code/commits:

  • Sometimes the commit message is a bit too long. Try to keep it around 50 characters and write more information in the body if needed.
  • I saw that you sometimes use line style. It's best practice to use an external stylesheet instead.
  • Only saw a few comments - maybe you could think about adding docstrings to your functions as well.

Looking forward to seeing more contributions in the future (and good luck with the task request for your coogger-python logo)!


Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.

To view those questions and the relevant answers related to your post, click here.


Need help? Write a ticket on https://support.utopian.io/.
Chat with us on Discord.
[utopian-moderator]

Sort:  

Thank you for reviewing and your advise @amosbastian I am going to adding docstrings to the functions and class' to next commit, I think it will be more illustrative.

Thank you for your review, @amosbastian!

So far this week you've reviewed 13 contributions. Keep up the good work!