RE: 👨🏼💻 #Proposal-86: Share Your Thoughts 📢
Alternatively, I would have suggested a "scroll top button". But the sticky navigation is a better solution.
I considered both but when I was researching design patterns, anything floating on the screen found a way of obstructing something at some point... which would be more of a concern on mobile where it would overlay a post (or similar).
The navigation bar does not contain any icons (when not logged in), whereas the icons are displayed in the navigation after logging in. The icons are currently only visible under "My Profile".
Would you mind sharing a screenshot? I'm not able to replicate this (unless "icon" hasn't translated appropriately 🙂)
In the navigation bar (not logged in) under "My Profile" it only shows "Wallet". It should probably be 'My Wallet' here.
It should 🙂 Although I should adjust some of these labels to use the language files.
When I open a post from your blog, the navigation still contains "@the-gorilla". Even if a post by another author is opened. Is that how it should be? I would intuitively expect informations from the author or alternatively informations from the logged-in user.
When you open a post, because the Post can be accessed from pretty much anywhere in the site, the navigation maintains the referring location so in this example, if you open a post from my feed/blog, then this will remain highlighted. I've struggled to think of the best solution for this and would appreciate an alternative view / idea. For example, I could move the navigation to the blog of that user but I don't know if this is intuitive if you've come from a community. I've found this quite tricky to figure out.
When I open a link with copy+paste in the address bar, the navigation bar appears in a shortened version without the user name. This is probably the result of the memory problem described in your previous post.
Exactly - since I use the referring location (which only works if you've come from another page on Steemit), the navigation defaults to the default "Explore > All Posts". Depending upon thoughts on the above idea, I could do it so that it highlights the user's blog.
I wonder what your thoughts are on this idea...
If the user views a post from a community, the navigation remains in the community. If they don't, or they come from a direct URL, then the navigation highlights their Posts or Blog feed. Perhaps this will work better than the current solution. Maybe if I keep it even simpler and just highlight the Poster's Profile (with a summary of profile details appearing in the Right Sidebar in a future release).
Do I understand correctly: You want to make a PR for the Condenser for this interim status regarding the navigation?
That's correct. My plan is to implement a change and once it's tested and ready, submit it for launch - so that the site is updated incrementally.
Thank you for the feedback, hopefully I've covered everything 🙂
Of course. But, I don't know what I had discovered. Maybe I wasn't quite awake anymore...
The login has nothing to do with it. It probably depends on whether you are looking at your own profile or that of another user.
not logged in
logged in as @moecki
Right. I think it could get confusing if the navigation changes when viewing posts. If the navigation looks different in different sections (e.g. between profile and post), this is immediately understandable. But when I jump from one post to the next, the navigation should stay the same.
The poster's profile could actually appear in a smaller panel and with it the possibility to get to his profile or posts/comments... something like this (maybe with more informations - as you described in your other comment):
Okay, then I would submit my modifications after yours. I would then probably mainly have to adapt the new UserProfile / Navigation component. I'll have to have a look at that.
It might be easiest if you would already provide a (still invisible) component as a placeholder. (By the way, I recently updated my bookmark branch)
Yes, that's it. For 3rd level navigation items (i.e. another person's profile and subscriptions), I removed the icons because whilst the nesting and indenting of icons looked ok for 2 levels deep, it started to look "overkill" with the 3rd. I also considered that with each indentation, the width available for the text reduced too so it reached the point where we were using 1/4 to 1/3rd of the navigation width for white space and icons. I love white space and I love the imagery but in my opinion, it became too much.
I like the idea of doing that - and allowing the user to continue to explore a user they've just read. Rather than adding another navigation underneath the current one, this feels like the ideal "supporting content" that would sit in the Right Sidebar. Within a post, the sidebar currently contains the Announcements and Trending Communities Components which aren't contextually relevant and provide little additional value.
I'd have to create a new component for this (and I'm thinking that the best approach would be to have a "Right Sidebar" or "Contextual Content" component that is implemented consistently across the site, and the component handles what displays - much like the navigation component). Definitely something worth doing and perhaps a good "next iteration", rather than within the existing.
I think that we could do this in either order - I could include a link to the bookmarks and comment it out. All I'd need for now is the name of the SVG you've used and the translation reference and it'll just need switching on in 2 locations.
Nothing else will need changing because the logic for each Profile page will highlight the appropriate section based upon the URL (I've assumed that the URL you've used ends with /bookmarks - if not, then the above lines of code are all that need changing).
What's the URL for your bookmark branch? I couldn't find it the last time I looked. I could merge your language file and bookmarks image in now to save a job later.
I think so too. In order to be able to display further data of the author, further data (last comment, last post, last vote etc.) would have to be requested. So far, these are not stored in the redux store.
Right. In section
bookmarksI added an additional div component that contains the sorting options.Maybe you've missed my reply to your comment so far. I linked the branches there. The main parts are finished. The texts and a few little things still need to be done.
Ah, lovely. Thank you. I did miss that message - perhaps this was when comments were taking many hours to appear!
This is going to continue to chip away in my subconscious...
I'm beginning to really like this idea. If you're reading a post by an author, the navigation is "encouraging" you to explore more about that user. And it's intuitive that if you're reading their content, that you're within their profile. The user will remember where they've come from and can return their with the "Back button".