Steemit patch submitted - Vote % in voters dropdown

in #steemdev8 years ago (edited)

About a month ago, I discovered a feature on Golos that I really wanted to see migrated over to Steemit, and made a post about it :

A golos feature I'd love to see on Steemit (vote % in dropdowns)

The topic got a lot of support, and users seemed pretty positive about wanting the feature implemented here.

I dug through the golos code at the time, figured out roughly what was needed to make it happen and made an elite github issue to track it :

Issue 1337

Now that I have some server resources, I've spun up my own copy of Steemit, made the required changes, and tested that nothing else somehow broke along the way.

Here's a screenshot of the votebox on my original post about this issue, running locally with vote percentages being displayed :

I'm convinced it all looks good, and I've submitted a pull request to make this change live for everyone here :

Pull Request 1433

Fingers crossed everything is well and we have this feature enabled soon!

Like what I'm up to ? Consider voting for my witness!
Current rank: 48


Lets connect !
steemit / twitter / gab.ai / keybase / steemit.chat / patreon
I also made :
steemviz / steemvids / steemcap / steemleak / more tools / post index

Sort:  

Awesome!!!!!!

I am so excited to see another community dev working on the condenser code base :) Great job! You already have my witness vote, but if I could vote for you again I would :)

Now now, this is a great addition to the site (although I have very limited experience being new to the community); however, if you had the ability to keep upvoting you would just dilute the pool. We don't want to have to add that blue junk to the pool to see whenever people upvote multiple times do we? (Pool humor and possibly in the realm of bad-dad joke, gotta love it).

yeah Golos has some cool stuff ;)

Great to read such enthusiasm and collaboration! May the force rise with us all!!! Namaste :)

This is great! Thank you @ausbitbank :)

I hope to see this change implemented in the near future. I will be casting my witness votes soon and will be voting for you.

Bright Blessings & Happy Steeming! <3

oh nice nice nice this is great. Looking forward to its implementation. so impressed

i agree.
we should also be able to see the voters not listed as well.
atm we see 'and x more' but you cant click to see who's voted, you have to go to https://steemd.com/ to see that.
btw how many newbies and non techies even know about steemd.com ?
https://steemd.com/

Steemd isn't the nicest looking but it's solid and reliable..
SteemdB is a bit slicker with more info that I'd probably recommend to new users first

Second that.

oh yes that's definitely a great feature - gotta get that accepted in! 👏👏👏 while you're at it, might even be cool to add popup access to the complete voter list for the post as well!

Great work!

I have always wanted to see the %'s.

I already voted for you for witness. If I could I would vote twice.

Yes, this would be a great feature to add.

That looks nice, I hope it gets implemented. Good work sir!