You are viewing a single comment's thread from:

RE: Blockcoinex | Exchange information STEEM, BTC, LTC, TRY etc with exchange platforms.

in #utopian-io6 years ago

Thanks for the contribution, @hakancelik! I'm not sure how useful something like this is, to be honest. Would you mind explaining why someone would use this Python package over other ones and give an example? (I know you gave examples of how to use the code, but not why and in what capacity someone could use it for).

Some other thoughts:

  • Commit messages could be improved
  • The docstrings are okay, but I would recommend using a proper docstring format like reST
  • Add whitespace after :, ,
  • Line width < 80 characters
  • No spaces around keyword / parameter equals (e.g. withdraw_btc_fee = 0.001 -> withdraw_btc_fee=0.001). Also the parameters are under-indented.
  • You are mixing camelCase and snake_case - why?

Most of these things could be solved by installing a linter like pep8 or pylint. I also think you could improve the formatting and presentation of your post (here's a good example).

Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.

To view those questions and the relevant answers related to your post, click here.


Need help? Write a ticket on https://support.utopian.io/.
Chat with us on Discord.
[utopian-moderator]

Sort:  

Hi, @amosbastian thanks for review.

What is Blockcoinex python library?

I thought I was talking about why it should be used under this heading.


Thanks for your advice, I follow the advice and this is helping me in development.

Coin Marketplace

STEEM 0.17
TRX 0.16
JST 0.029
BTC 62151.48
ETH 2421.34
USDT 1.00
SBD 2.57