You are viewing a single comment's thread from:

RE: New Project: Adonis-Auth-Scaffold— Painless auth scaffolding for your Adonis.js app in one sexy command.

in #utopian-io6 years ago

Thank you for your contribution @creatrixity ! Interesting project

  1. The link of https://github.com/adonisjs/persona is 404
  2. I can see you are delibrately ignoring some errors, would it be better to log these errors in case of failure.
  3. inconsistent line endings with ';' or not.
  4. good usages of async/await however I think _ensureInProjectRoot does not have to be asynchronous.

BTW, the image quality on the README is very low. You might want to replace it with a better one.

Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.

To view those questions and the relevant answers related to your post, click here.


Need help? Chat with us on Discord.

[utopian-moderator]

Sort:  

Thank you for your review, @justyy! Keep up the good work!