You are viewing a single comment's thread from:
RE: [utopian-io] ips-util - Python package for manipulating IPS patches
Thank you for your contribution. I am a fan of the vintage game consoles e.g. 8-bit super mario. So does this utility work on 8-bit ROM files?
From the documentation, I can see it is a complete and useful tool and good job for putting it on pip
.
- It would be good to see some real ROM files in your test scripts e.g. you can put the ROM under
testdata
directories. - When dealing with I/O, I feel that the try...catch is kinda missing.
- It is better to group your commits into a PR.
- If a binary file is empty, your
Path.load
will probably throw exception? - You might want to add a command-line option to enable the debugger output.
Your contribution has been evaluated according to Utopian policies and guidelines, as well as a predefined set of questions pertaining to the category.
To view those questions and the relevant answers related to your post, click here.
Need help? Write a ticket on https://support.utopian.io/.
Chat with us on Discord.
[utopian-moderator]
Thank you for your review, @justyy! Keep up the good work!